Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update follow_me_example to use MAVSDK v2 #709

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

dpfrakes
Copy link
Contributor

Changes

  • Replace direction = Config.FollowDirection.BEHIND with follow_angle_deg = 0 in follow_me_example.py
  • Add new required args to follow_me Config()

History

julianoes
julianoes previously approved these changes Jun 15, 2024
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Can you check CI?

@dpfrakes
Copy link
Contributor Author

Thanks a lot! Can you check CI?

Thanks for the quick review! CI should pass now. I haven't actually gotten this new "follow angle" working yet in my SITL sim (I'm setting TargetLocation periodically based on the latest position of a leader node) but the updated example here should now include valid API calls.

@dpfrakes dpfrakes requested a review from julianoes June 18, 2024 12:51
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dpfrakes!

@julianoes julianoes merged commit 02c8dce into mavlink:main Jun 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants