Default defines for MSVC causes compile/preprocessor error for some win32 headers

[Maldivia]

The default defines for C/C++ compilers on Windows defines "Windows" and "WIN32".

The definition of "Windows" clashes with the shldisp.h header file from the Win32 API (which is included if you try to use any shell32.dll functions) -- which results in a lot of error messages.

I know this can be resolved by overriding the default defines, but it might be worth taking into account in the future, including if, by default, defining something not in all uppercase is a good idea.

[dscho]

@Maldivia Version 3.2.0 of the NAR plugin is imminent. Feel free to contribute a pull request if you want to see this issue fixed in that release. Thank you for your contribution!

[dscho]

I will start the release procedure in half an hour unless I hear back from you...

[dscho]

Sorry, 3.2.0 without your contribution... But maybe not 3.2.1?

[Maldivia]

Since noone else have commented on it previously, it doesn't seem that pressing an issue; and I don't know if people are actually using that define, and if changing that will break stuff for them.

I'll make a pull request later, then you can evaluate if it's something you think is worth changing, or if it's just something that people should keep in mind when compiling against Win32.

[dscho]

@Maldivia do you have any news on this issue?