-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set an int64 file control #1298
base: master
Are you sure you want to change the base?
Conversation
I filed #1299 for this bug. |
CIFuzz failure was caused by #1300. I'll rebase this and hopefully that fixes the issue 🤞 |
Co-authored-by: rittneje <rittneje@gmail.com>
80b9472
to
3e99090
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mattn any concerns on your end?
Similar to #1000,
We are using
vfs=memdb
and would like to use theSQLITE_FCNTL_SIZE_LIMIT
opcode withsqlite3_file_control
:Calling the existing
SetFileControlInt
method when go decides thatint
s areint64
based on your architecture seem to overflow theC.int
and in our case set the size limit of our in-memory VFS to 0. This adds a newSetFileControlInt64
to be used with op codes that expect asqlite3_int64
.