Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code/ subdirectory is not properly handled by the go tool #293

Closed
dgsb opened this issue Apr 2, 2016 · 4 comments
Closed

code/ subdirectory is not properly handled by the go tool #293

dgsb opened this issue Apr 2, 2016 · 4 comments

Comments

@dgsb
Copy link
Contributor

dgsb commented Apr 2, 2016

The sqlite3 amalgamation files are ignored by the go tool. It does not cause any issue during the buils as these files are included by higher level other C files, but it prevent to easily vendor this package with the help of godep for instance. The command go list -json should list these file somehow.
dgsb added a commit to dgsb/go-sqlite3 that referenced this issue Apr 2, 2016
@dgsb
Move sqlite3 amalgation files a directory up.
3a55553 
The purpose is to ease the use of vendoring files like godep.
The C sqlite3 files have been added a go compilation conditional flag
Fix mattn#293
@dgsb dgsb mentioned this issue Apr 2, 2016
Merged
@ghost
Copy link

ghost commented Apr 6, 2016

Hi,
We are facing a similar issue related to godep when trying to build a static binary. Here is my stack trace:

++ go install -v github.com/mattn/go-sqlite3
github.com/mattn/go-sqlite3
# github.com/mattn/go-sqlite3
In file included from ../github.com/mattn/go-sqlite3/backup.go:9:0:
./sqlite3-binding.h:2:34: fatal error: code/sqlite3-binding.h: No such file or directory
 #include "code/sqlite3-binding.h"
                                  ^
compilation terminated.

We will really appreciate a quick resolution of this issue.

@mattn
Copy link
Owner

mattn commented Apr 7, 2016

okay could you please make pull-request?

@ghost
Copy link

ghost commented Apr 7, 2016

@mattn, I have tried the pull request from @dgsb. That fixed build issues for me.

@dgsb
Copy link
Contributor Author

dgsb commented Apr 7, 2016

@codefx9 you might also try to migrate your project to constabulary/gb, which works like a charm.

@dgsb dgsb mentioned this issue Sep 15, 2016
Closed
@0x6c66 0x6c66 mentioned this issue Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update go-sqlite3 to fix build issues
2 participants
@mattn @dgsb