removing ceil from progress generation

Author: mattjburrows

app/components/Progress.jsx

@@ -7,11 +7,10 @@ function workOutProgressValue(duration, currentTime) {
   const remainingTime = (duration - difference);
   const progressPercentage = (remainingTime / duration) * 100;
 
-  return Math.ceil(progressPercentage);
+  return progressPercentage;
 }
 
 class Progress extends Component {
-
   render() {
     const progress = workOutProgressValue(this.props.duration, this.props.currentTime);
 

app/store/mapStoreToPlayer.js

@@ -25,7 +25,7 @@ function setupPlayer(player) {
 function setupDispatch(store, player) {
   player.addEventListener('ended', () => store.dispatch(hasStopped(true)));
   player.addEventListener('loadedmetadata', () => {
-    const duration = Math.ceil(parseFloat(player.duration));
+    const duration = parseFloat(player.duration);
     store.dispatch(setDuration(duration));
   });
   player.addEventListener('timeupdate', () => {

test/components/Progress.js

@@ -15,13 +15,13 @@ describe('<Progress />', () => {
     assert.equal(wrapper.find('progress').prop('max'), 100);
   });
 
-  it('adds 35 as the value on the progress tag', () => {
-    const currentTime = 666;
+  it('adds 50 as the value on the progress tag', () => {
+    const currentTime = 1000;
     const duration = 2000;
     const wrapper = shallow(
       <Progress currentTime={currentTime} duration={duration} />
     );
 
-    assert.equal(wrapper.find('progress').prop('value'), 34);
+    assert.equal(wrapper.find('progress').prop('value'), 50);
   });
 });

test/store/mapStoreToPlayer.js

@@ -156,14 +156,14 @@ describe('mapStoreToPlayer', () => {
       unsubscribe();
     });
 
-    it('dispatched SET_DURATION: {NUMBER} when the player is loaded', () => {
+    it('dispatched SET_DURATION: {NUMBER} when the player metadata is loaded', () => {
       const player = setupPlayer({
         duration: 74.5
       });
       const unsubscribe = mapStoreToPlayer(store, player);
       const expectedCallArgs = {
         type: SET_DURATION,
-        duration: 75
+        duration: 74.5
       };
 
       player.loadedmetadata();