Skip to content

Commit d63a067

Browse files
committed
Add fixme for removing LlvmArchiveBuilder in the future
1 parent c1f5350 commit d63a067

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

compiler/rustc_codegen_llvm/src/back/archive.rs

+4
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,10 @@ pub struct LlvmArchiveBuilderBuilder;
106106

107107
impl ArchiveBuilderBuilder for LlvmArchiveBuilderBuilder {
108108
fn new_archive_builder<'a>(&self, sess: &'a Session) -> Box<dyn ArchiveBuilder + 'a> {
109+
// Keeping LlvmArchiveBuilder around in case of a regression caused by using
110+
// ArArchiveBuilder.
111+
// FIXME remove a couple of months after #128936 gets merged in case no
112+
// regression is found.
109113
if false {
110114
Box::new(LlvmArchiveBuilder { sess, additions: Vec::new() })
111115
} else {

0 commit comments

Comments
 (0)