Skip to content

Commit 764c3c7

Browse files
committed
Fix issue that made empty string attribute values trigger changedCallback instead of disconnectedCallback removing an attribute
1 parent 261c660 commit 764c3c7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

attr.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ class CustomAttributeRegistry {
120120
}
121121
}
122122
// Attribute was removed
123-
else if(newVal == null && !!inst.value) {
123+
else if(newVal == null) {
124124
inst.value = newVal;
125125
if(inst.disconnectedCallback) {
126126
inst.disconnectedCallback();

registry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ class CustomAttributeRegistry {
117117
}
118118
}
119119
// Attribute was removed
120-
else if(newVal == null && !!inst.value) {
120+
else if(newVal == null) {
121121
inst.value = newVal;
122122
if(inst.disconnectedCallback) {
123123
inst.disconnectedCallback();

0 commit comments

Comments
 (0)