Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support excluding specific comment authors for issue comment subscriptions #739

Open
mickmister opened this issue Feb 7, 2024 · 6 comments
Labels
Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Contributor

mickmister commented Feb 7, 2024

Comments from the codecov bot can be a bit spammy in channels subscribing to issue/PR comments. For my use case of the GitHub issue comments subscription, I would like to exclude the codecov bot from creating issue comments in the issue comment subscription.

The task here is to implement a --exclude-users flag that can take a comma-separated list of GitHub usernames to exclude from the subscription posts. This is currently implemented for DM notifications through the mute command, though is not accessible in the subscriptions feature

func (p *Plugin) handleMuteCommand(_ *plugin.Context, args *model.CommandArgs, parameters []string, userInfo *GitHubUserInfo) string {

@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers labels Feb 7, 2024
@hanzei
Copy link
Contributor

hanzei commented Feb 7, 2024

FYI: There is already a per-user setting in the form of /github mute. It seems useful to me to have both (a per-subscription and a per-user mute) 👍

@mickmister
Copy link
Contributor Author

mickmister commented Feb 8, 2024

@hanzei Funny enough, I had that in the issue description but removed it for some reason

Are you suggesting we call the flag mute when creating/editing the subscription?

@mickmister
Copy link
Contributor Author

@hanzei I'd like to move this ticket to the monorepo to increase visibility. Do you have any thoughts on my question above?

@hanzei
Copy link
Contributor

hanzei commented Mar 5, 2024

My concern is more about whether this setting should be per-user, per-subscription or global. There is already a per-user one. What value does a per-subscription setting add?

@mickmister
Copy link
Contributor Author

@hanzei The per-user one is for DM notifications. How are you proposing this feature should work? I guess I'm simply not understanding what the exact suggestion is

@mickmister
Copy link
Contributor Author

@hanzei Do you think this would work well? Or how do you see this working?

/github subscriptions add mattermost/mattermost-plugin-github --exclude-users codecov,mattermod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

2 participants