Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach modal shows a json error when no issues are available to attach #537

Closed
DHaussermann opened this issue Feb 16, 2022 · 2 comments
Closed
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Type/Bug Something isn't working
Milestone

Comments

@DHaussermann
Copy link

DHaussermann commented Feb 16, 2022

When no issues are available to attach we should see s friendly message rather than a json error. This would be most common the plugin is locked to an org or repo and issue creation has been disabled there.

image

Steps:

  • Connect a test user
  • Save some other value in the Organization lock such as token-org (or find an org or repo that has issue creation disabled and point there)
  • Make or locate a post
  • Select the ... menu and Attach to GitHub

Observed: The modal shown an invalid json error

@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Feb 16, 2022
@hanzei hanzei added Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Triage labels Feb 18, 2022
@Kshitij-Katiyar
Copy link
Contributor

Hey @DHaussermann @wiggin77 ,
I attempted to reproduce the issue but was unable to do so. I tested various configurations of organizations and repositories with issue creation disabled but still could not replicate the problem. It's possible that the issue was resolved as part of another fix.

@raghavaggarwal2308
Copy link
Contributor

Closing as fixed for now

@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Sep 2, 2024
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants