Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only channel admins should be able to create subscription #488

Open
mickmister opened this issue Oct 4, 2021 · 3 comments
Open

Only channel admins should be able to create subscription #488

mickmister opened this issue Oct 4, 2021 · 3 comments
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Milestone
v2.4.0

Comments

@mickmister
Copy link
Contributor

mickmister commented Oct 4, 2021 •
edited
Loading

At the moment, any user can create/edit/delete GitHub subscriptions. This functionality should be limited to users with permission to manage the given channel. The following cases should allow a user to edit subscriptions:

  • The channel is a private channel and the user has PERMISSION_MANAGE_PRIVATE_CHANNEL_PROPERTIES for this channel
  • The channel is a public channel and the user has PERMISSION_MANAGE_PUBLIC_CHANNEL_PROPERTIES for this channel
  • The channel is a direct message (DM)
  • The channel is a group message (GM)

Issue created from a Mattermost message by @hanzei.
@mickmister mickmister added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers labels Oct 4, 2021
@GibranHL0
Copy link

Hi 👋

I'd like to be assigned to this issue and give it a try.

@hanzei
Copy link
Contributor

hanzei commented Oct 4, 2021

Awesome, thanks @GibranHL0 🎉 Please let me know if you have any questions.

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 4, 2021
@GibranHL0 GibranHL0 removed their assignment Nov 2, 2021
@Kshitij-Katiyar Kshitij-Katiyar added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Sep 24, 2024
@Kshitij-Katiyar Kshitij-Katiyar added this to the v2.4.0 milestone Sep 24, 2024
@Kshitij-Katiyar
Copy link
Contributor

Kshitij-Katiyar commented Sep 27, 2024 •
edited
Loading

Hey @wiggin77, This functionality is implemented in Jira via plugin configs
Screenshot from 2024-09-27 13-00-58
Should we implement this on the Github plugin also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
4 participants
@mickmister @hanzei @GibranHL0 @Kshitij-Katiyar