Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User gets unfriendly validation when GitHub domain is uppercase. #482

Closed
DHaussermann opened this issue Sep 21, 2021 · 4 comments
Closed
Assignees
Labels
Type/Bug Something isn't working

Comments

@DHaussermann
Copy link

When trying to create a subscription where the GitHub domain is in uppercase letters the user gets an invalid / unfriendly validation issue.
image

Steps:

  • Install GitHub and connect a test user
  • Post /github subscriptions add https://GITHUB.COM/DHAUSSERMANN/HELLO-WORLD
    Observed: Unknown organization https:
    Expected: Not sure this is something that must work but, the validation message should not mention Unknown organization https: Ideally we would support this or inform the user the URL is the issue.
@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Sep 21, 2021
@mickmister
Copy link
Contributor

@DHaussermann The error Unknown organization https: is unrelated to the uppercase issue. The expected input here would be only DHaussermann/hello-world, and not the full URL. 1/5 we should support pasting the repo's full URL as you've attempted here.

Going to https://github.com/dhaussermann (no uppercase letters), GitHub takes me to the right page. Maybe the GitHub entities are case insensitive. That would require some investigation to determine.

@catalintomai
Copy link

Add @DHaussermann to detail the lack of support(?) for full Urls?

@Kshitij-Katiyar
Copy link
Contributor

@DHaussermann @mickmister From the discussion above and from the #501. Should we close this issue?

@mickmister
Copy link
Contributor

@Kshitij-Katiyar Yeah I think we can close. No need to support all caps URL imo, in case we are currently not supporting that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants