Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification numbers are not properly aligned #398

Open
agarciamontoro opened this issue Oct 21, 2020 · 7 comments
Open

Notification numbers are not properly aligned #398

agarciamontoro opened this issue Oct 21, 2020 · 7 comments
Assignees
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted

Comments

@agarciamontoro
Copy link
Member

The numbers in the left hand side bar are not properly aligned, which is very obvious when all the numbers are the same ones, as in the following screenshot:

image

We need to fix the CSS so they are aligned. I'm not sure if the best way would be to assign the same width to the icons, or to align the icons and the numbers separately.

@agarciamontoro agarciamontoro added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Hacktoberfest Good First Issue Suitable for first-time contributors Difficulty/1:Easy Easy ticket labels Oct 21, 2020
@RabsonJ
Copy link

RabsonJ commented Oct 21, 2020

I would love to work on this

@hanzei
Copy link
Contributor

hanzei commented Oct 21, 2020

Awesome, thanks @RabsonJ 👍

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 21, 2020
@RabsonJ
Copy link

RabsonJ commented Oct 21, 2020

Awesome, thanks @RabsonJ 👍

Thank you! Let me get working

@RabsonJ
Copy link

RabsonJ commented Oct 21, 2020

@hanzei can you please give me the exact name of the file / it's location

@hanzei
Copy link
Contributor

hanzei commented Oct 21, 2020

Sure @RabsonJ. The button are defined in https://github.com/mattermost/mattermost-plugin-github/blob/master/webapp/src/components/sidebar_buttons/sidebar_buttons.jsx. You might want to take a look at the getStyle method first:

const getStyle = makeStyleFromTheme((theme) => {
return {
buttonTeam: {
color: changeOpacity(theme.sidebarText, 0.6),
display: 'block',
marginBottom: '10px',
width: '100%',
},
buttonHeader: {
color: changeOpacity(theme.sidebarText, 0.6),
textAlign: 'center',
cursor: 'pointer',
},
containerHeader: {
marginTop: '10px',
marginBottom: '5px',
display: 'flex',
alignItems: 'center',
justifyContent: 'space-around',
padding: '0 10px',
},
containerTeam: {
},
};
});

@hanzei hanzei added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Aug 20, 2021
@JanumalaAkhilendra
Copy link

I would Like to work on this issue .

@agarciamontoro
Copy link
Member Author

Go ahead, @JanumalaAkhilendra, all yours!

@agarciamontoro agarciamontoro removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants