Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate syntax when a subscription has an invalid label #385

Open
DHaussermann opened this issue Oct 7, 2020 · 4 comments
Open

Validate syntax when a subscription has an invalid label #385

DHaussermann opened this issue Oct 7, 2020 · 4 comments
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@DHaussermann
Copy link

DHaussermann commented Oct 7, 2020

If a user mistakenly forgets the " on the label, the label has no affect and it's not obvious why.

Ideally we can prevent this by checking if label: is followed by a value in quotes to prevent user error. If we showed a message such as no valid label provided this would be far more forgiving.

Steps:

  • type /github subscribe DHaussermann/hello-world pulls,issues,creates,deletes,label:Apples with Apples instead of "Apples"
  • Subscription successful

Observed Label has no affect as no valid label was provided

@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Oct 7, 2020
@DHaussermann
Copy link
Author

@hanzei please advise if this is technically possible and would make a good help wanted.

@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Type/Bug Something isn't working Triage labels Oct 8, 2020
@hanzei
Copy link
Contributor

hanzei commented Oct 8, 2020

That improvement makes up for a great HW 👍

@NamrataSitlani
Copy link

NamrataSitlani commented Oct 8, 2020

@DHaussermann @hanzei Hi, I would like to assign this issue to myself, and give it a try.

@hanzei
Copy link
Contributor

hanzei commented Oct 8, 2020

Awesome, thanks for taking a look @NamrataSitlani. Let me know if you have any questions.

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 8, 2020
@Kshitij-Katiyar Kshitij-Katiyar added the Up For Grabs Ready for help from the community. Removed when someone volunteers label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

6 participants