Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render tooltip for Enterprise installations #367

Open
hanzei opened this issue Sep 18, 2020 · 0 comments
Open

Render tooltip for Enterprise installations #367

hanzei opened this issue Sep 18, 2020 · 0 comments
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@hanzei
Copy link
Contributor

hanzei commented Sep 18, 2020

The link tooltip currently only works for links to github.com. It should also work for link to the configured Enterprise installations, if there is one.

mattermost-plugin-github/webapp/src/components/link_tooltip/link_tooltip.jsx

Line 15 in e9247ee

const [owner, repo, type, number] = href.split('github.com/')[1].split('/');
is the line in question.
@hanzei hanzei added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Tech/ReactJS Difficulty/2:Medium Medium ticket Type/Enhancement New feature or improvement of existing feature labels Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jespino @cpanato @hanzei