Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render markdown in tooltip with post-utils, instead of ReactMarkdown #327

Open
mickmister opened this issue Jul 12, 2020 · 0 comments
Open
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Contributor

The webapp has a robust markdown system that I think we should utilize instead of using the ReactMarkdown library:

<ReactMarkdown
source={data.body}
disallowedTypes={['heading']}
linkTarget='_blank'
/>

The todo plugin uses the webapp's exposed post-utils to render its markdown. I think it makes sense to do the same here. This would allow for feature-rich things like at-mentions to be rendered as well, assuming the backend does the same sort of translations of GitHub -> Mattermost usernames before the PR description is delivered to the frontend, as it does when it creates posts from a GitHub event.

@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Tech/Go Good First Issue Suitable for first-time contributors Tech/ReactJS Difficulty/1:Easy Easy ticket Type/Enhancement New feature or improvement of existing feature labels Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

3 participants