Prefix metrics_profile name with ClusterName #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we create conflicts with other clusters currently deployed.
agnivade
approved these changes
Sep 26, 2024
isacikgoz
approved these changes
Sep 26, 2024
isacikgoz
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#798 introduced a new
aws_iam_instance_profilewhose name was hard-coded tometrics_profile. Of course, that creates conflicts with other currently deployed clusters, throwing this error:We need to make that name unique as we do with all other resources: prefixing its name with the ClusterName specified in deployer.json.
Thanks @streamer45 for catching this!
Ticket Link
--