-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tapping on iOS 12 doesn't work properly with multiple line labels #106
Comments
@matteobortolazzo is this fixed? I have a bug in our app that neds fixing today, if there is a fix any chance of a beta or preview release today? |
@IeuanWalker I cannot test it so I trust @dbard PR |
@matteobortolazzo thanks for releasing it so quickly. Unfortunately version 4.1.3 still doesn't work for me. I'm using a iOS 13.5 emulator. |
I am sorry to head that! Unfortunately I cannot work on that right now. Can you please try version 5 (alpha) then? |
@matteobortolazzo i can confirm link and phone numbers are working, but email link isn't. The control is wrapped in a scrollview, but is only scrollable when the view is refreshed with hot reload. Wasnt an issue on older versions |
Got it, can add those issues as comments in pr #104 please? |
@matteobortolazzo done. As i need this fixed my self are you ok with me messing around with that PR? cant promise anything though. |
Sure, help is always welcome :) thanks |
Note that the code I provided was meant to address that there was some unnecessary math being performed to determine total characters which wasn't necessary. It only addressed where on the screen a tap occurred, nothing to do with what happens within the library after the tap was correctly observed. |
@dbard sure, don't worry, your update is still valid! Thanks again |
@matteobortolazzo @dbard The scrollview works just text is cut off And this is the error that I'm getting when clicking the email link (also replicated in the above repo)
|
@matteobortolazzo Update I think the scrolling issue is do to this issue - xamarin/Xamarin.Forms#1332 So only issue I have now is around email links, but its not going to stop us releasing with it not working. So ill stick to v5 alpha for now, |
Got it, glad to hear. About emails, it looks like it is a EDIT: I think EDIT 2: Maybe I should have added Unit Tests for those extension methods. |
@matteobortolazzo Ye sure ill give it a test in a bit |
I use a simulator 90%, but turns out the Xamarin.Essentials email isn't supported on iOS simulators. Tested my project on a physical device and I'm getting a 'NullReferenceException' when clicking on an email link. I've imported the HtmlLabel project into mine (so I don't have to create provisioning profile to test on a physical device) and its throwing the error here - Updating the code to this fixes it - |
@matteobortolazzo PR created - #108 |
v5 Released |
If the user taps on a link appearing after the first line of a multiple line label, the link doesn't open. I was able to reproduce this using the test project with the Nuget.
I've put up a pull request with what I think is a good solution. #105
And... thank you for your work on this Nuget!!
The text was updated successfully, but these errors were encountered: