rector: InlineArrayReturnAssignRector (OpenMage#4868)

* rector: `InlineArrayReturnAssignRector`

- see https://getrector.com/rule-detail/inline-array-return-assign-rector

* cs

Author: sreichel

.rector.php

@@ -46,7 +46,6 @@
             CodeQuality\Class_\CompleteDynamicPropertiesRector::class, # todo: TMP (!?!)
             CodeQuality\Class_\InlineConstructorDefaultToPropertyRector::class, # todo: TMP
             CodeQuality\ClassMethod\ExplicitReturnNullRector::class, # todo: TMP
-            CodeQuality\ClassMethod\InlineArrayReturnAssignRector::class, # todo: TMP
             CodeQuality\Concat\JoinStringConcatRector::class, # todo: TMP
             CodeQuality\Empty_\SimplifyEmptyCheckOnEmptyArrayRector::class, # todo: TMP
             CodeQuality\Equal\UseIdenticalOverEqualWithSameTypeRector::class, # todo: TMP

app/code/core/Mage/Adminhtml/Model/System/Config/Source/Date/Short.php

@@ -15,12 +15,12 @@ class Mage_Adminhtml_Model_System_Config_Source_Date_Short
 {
     public function toOptionArray()
     {
-        $arr = [];
-        $arr[] = ['label' => '', 'value' => ''];
-        $arr[] = ['label' => sprintf('MM/DD/YY (%s)', date('m/d/y')), 'value' => '%m/%d/%y'];
-        $arr[] = ['label' => sprintf('MM/DD/YYYY (%s)', date('m/d/Y')), 'value' => '%m/%d/%Y'];
-        $arr[] = ['label' => sprintf('DD/MM/YY (%s)', date('d/m/y')), 'value' => '%d/%m/%y'];
-        $arr[] = ['label' => sprintf('DD/MM/YYYY (%s)', date('d/m/Y')), 'value' => '%d/%m/%Y'];
-        return $arr;
+        return [
+            ['label' => '', 'value' => ''],
+            ['label' => sprintf('MM/DD/YY (%s)', date('m/d/y')), 'value' => '%m/%d/%y'],
+            ['label' => sprintf('MM/DD/YYYY (%s)', date('m/d/Y')), 'value' => '%m/%d/%Y'],
+            ['label' => sprintf('DD/MM/YY (%s)', date('d/m/y')), 'value' => '%d/%m/%y'],
+            ['label' => sprintf('DD/MM/YYYY (%s)', date('d/m/Y')), 'value' => '%d/%m/%Y'],
+        ];
     }
 }

app/code/core/Mage/Catalog/Model/Category.php

@@ -607,11 +607,10 @@ public function getParentIds()
      */
     public function getCustomDesignDate()
     {
-        $result = [];
-        $result['from'] = $this->getData('custom_design_from');
-        $result['to'] = $this->getData('custom_design_to');
-
-        return $result;
+        return [
+            'from' => $this->getData('custom_design_from'),
+            'to' => $this->getData('custom_design_to'),
+        ];
     }
 
     /**

app/code/core/Mage/Catalog/Model/Product.php

@@ -1638,11 +1638,10 @@ public function getAttributeText($attributeCode)
      */
     public function getCustomDesignDate()
     {
-        $result = [];
-        $result['from'] = $this->getData('custom_design_from');
-        $result['to'] = $this->getData('custom_design_to');
-
-        return $result;
+        return [
+            'from' => $this->getData('custom_design_from'),
+            'to' => $this->getData('custom_design_to'),
+        ];
     }
 
     /**

app/code/core/Mage/Catalog/Model/Product/Compare/Item.php

@@ -142,12 +142,11 @@ public function addProductData($product)
      */
     public function getDataForSave()
     {
-        $data = [];
-        $data['customer_id'] = $this->getCustomerId();
-        $data['visitor_id']  = $this->getVisitorId();
-        $data['product_id']  = $this->getProductId();
-
-        return $data;
+        return [
+            'customer_id' => $this->getCustomerId(),
+            'visitor_id' => $this->getVisitorId(),
+            'product_id' => $this->getProductId(),
+        ];
     }
 
     /**

app/code/core/Mage/CatalogIndex/Model/Indexer/Tierprice.php

@@ -112,9 +112,6 @@ protected function _isAttributeIndexable(Mage_Eav_Model_Entity_Attribute_Abstrac
      */
     protected function _getIndexableAttributeConditions()
     {
-        $conditions = [];
-        $conditions['attribute_code'] = 'tier_price';
-
-        return $conditions;
+        return ['attribute_code' => 'tier_price'];
     }
 }

app/code/core/Mage/Core/Model/Config.php

@@ -1297,12 +1297,10 @@ public function loadEventObservers($area)
      */
     public function getPathVars($args = null)
     {
-        $path = [];
-
-        $path['baseUrl'] = Mage::getBaseUrl();
-        $path['baseSecureUrl'] = Mage::getBaseUrl('link', true);
-
-        return $path;
+        return [
+            'baseUrl' => Mage::getBaseUrl(),
+            'baseSecureUrl' => Mage::getBaseUrl('link', true),
+        ];
     }
 
     /**

app/code/core/Mage/Core/Model/Magento/Api.php

@@ -21,11 +21,10 @@ class Mage_Core_Model_Magento_Api extends Mage_Api_Model_Resource_Abstract
      */
     public function info()
     {
-        $result = [];
-        $result['magento_edition'] = Mage::getEdition();
-        $result['magento_version'] = Mage::getVersion();
-        $result['openmage_version'] = Mage::getOpenMageVersion();
-
-        return $result;
+        return [
+            'magento_edition' => Mage::getEdition(),
+            'magento_version' => Mage::getVersion(),
+            'openmage_version' => Mage::getOpenMageVersion(),
+        ];
     }
 }

app/code/core/Mage/Newsletter/Model/Queue.php

@@ -230,12 +230,12 @@ protected function _finishQueue()
      */
     public function getDataForSave()
     {
-        $data = [];
-        $data['template_id'] = $this->getTemplateId();
-        $data['queue_status'] = $this->getQueueStatus();
-        $data['queue_start_at'] = $this->getQueueStartAt();
-        $data['queue_finish_at'] = $this->getQueueFinishAt();
-        return $data;
+        return [
+            'template_id' => $this->getTemplateId(),
+            'queue_status' => $this->getQueueStatus(),
+            'queue_start_at' => $this->getQueueStartAt(),
+            'queue_finish_at' => $this->getQueueFinishAt(),
+        ];
     }
 
     /**

app/code/core/Mage/Sales/Model/Order/Shipment/Track.php

@@ -128,10 +128,10 @@ public function getNumberDetail()
     {
         $carrierInstance = Mage::getSingleton('shipping/config')->getCarrierInstance($this->getCarrierCode());
         if (!$carrierInstance) {
-            $custom = [];
-            $custom['title'] = $this->getTitle();
-            $custom['number'] = $this->getTrackNumber();
-            return $custom;
+            return [
+                'title' => $this->getTitle(),
+                'number' => $this->getTrackNumber(),
+            ];
         } else {
             $carrierInstance->setStore($this->getStore());
         }