Skip to content

/rooms/{roomId}/event/{eventId} should return a 404 when no perms #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2019
Merged

/rooms/{roomId}/event/{eventId} should return a 404 when no perms #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/30rooms/51event.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ sub matrix_get_event
method => "GET",
uri => "/r0/rooms/$room_id/event/${ \uri_escape( $event_id ) }",
);
})->main::expect_http_403;
})->main::expect_http_404;
};

test "/event/ does not allow access to events before the user joined",
Expand Down Expand Up @@ -103,7 +103,7 @@ sub matrix_get_event
method => "GET",
uri => "/r0/rooms/$room_id/event/${ \uri_escape( $event_id_1 ) }",
);
})->main::expect_http_403->then( sub {
})->main::expect_http_404->then( sub {
# we should be able to get the event after we joined.
do_request_json_for( $other_user,
method => "GET",
Expand Down