Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Support for routing outbound HTTP requests via a proxy #6239

Merged
merged 8 commits into from
Nov 1, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 23, 2019

The http_proxy and HTTPS_PROXY env vars can be set to a host[:port] value which should point to a proxy.

The address of the proxy should be excluded from IP blacklists such as the url_preview_ip_range_blacklist.

The proxy will then be used for

  • push
  • url previews
  • phone-home stats
  • recaptcha validation
  • CAS auth validation

It will not be used for:

  • Application Services
  • Identity servers
  • Outbound federation
  • In worker configurations, connections from workers to masters

Fixes #4198.

@richvdh richvdh changed the title This PR implements support for routing outbound HTTP requests via a proxy. Support for routing outbound HTTP requests via a proxy Oct 23, 2019
@richvdh richvdh requested a review from a team October 23, 2019 10:18
Copy link
Contributor

@hawkowl hawkowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from the nit

synapse/rest/media/v1/preview_url_resource.py Show resolved Hide resolved
@richvdh richvdh merged commit 1cb84c6 into develop Nov 1, 2019
anoadragon453 pushed a commit that referenced this pull request Jan 24, 2020
The `http_proxy` and `HTTPS_PROXY` env vars can be set to a `host[:port]` value which should point to a proxy.

The address of the proxy should be excluded from IP blacklists such as the `url_preview_ip_range_blacklist`.

The proxy will then be used for
 * push
 * url previews
 * phone-home stats
 * recaptcha validation
 * CAS auth validation

It will *not* be used for:
 * Application Services
 * Identity servers
 * Outbound federation
 * In worker configurations, connections from workers to masters

Fixes #4198.
@richvdh richvdh deleted the rav/proxy-support branch December 1, 2020 12:35
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '1cb84c648':
  Support for routing outbound HTTP requests via a proxy (#6239)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants