This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support for routing outbound HTTP requests via a proxy #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix some bugs on python 3 * better docstrings * tests
richvdh
changed the title
This PR implements support for routing outbound HTTP requests via a proxy.
Support for routing outbound HTTP requests via a proxy
Oct 23, 2019
richvdh
force-pushed
the
rav/proxy-support
branch
from
October 23, 2019 13:06
73a1ca7
to
babe9dd
Compare
richvdh
force-pushed
the
rav/proxy-support
branch
from
October 23, 2019 13:17
babe9dd
to
0bfc18d
Compare
richvdh
force-pushed
the
rav/proxy-support
branch
from
October 23, 2019 14:25
0bfc18d
to
5ecc002
Compare
hawkowl
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from the nit
anoadragon453
pushed a commit
that referenced
this pull request
Jan 24, 2020
The `http_proxy` and `HTTPS_PROXY` env vars can be set to a `host[:port]` value which should point to a proxy. The address of the proxy should be excluded from IP blacklists such as the `url_preview_ip_range_blacklist`. The proxy will then be used for * push * url previews * phone-home stats * recaptcha validation * CAS auth validation It will *not* be used for: * Application Services * Identity servers * Outbound federation * In worker configurations, connections from workers to masters Fixes #4198.
4 tasks
4 tasks
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '1cb84c648': Support for routing outbound HTTP requests via a proxy (#6239)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
http_proxy
andHTTPS_PROXY
env vars can be set to ahost[:port]
value which should point to a proxy.The address of the proxy should be excluded from IP blacklists such as the
url_preview_ip_range_blacklist
.The proxy will then be used for
It will not be used for:
Fixes #4198.