Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Correctly handle HttpResponseException when handling device updates #4668

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

erikjohnston
Copy link
Member

No description provided.

@richvdh
Copy link
Member

richvdh commented Feb 18, 2019

related: #4643

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@richvdh
Copy link
Member

richvdh commented Feb 18, 2019

modulo CI failing

@codecov-io
Copy link

Codecov Report

Merging #4668 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #4668      +/-   ##
===========================================
- Coverage    75.27%   75.26%   -0.01%     
===========================================
  Files          338      338              
  Lines        34626    34626              
  Branches      5670     5670              
===========================================
- Hits         26064    26062       -2     
- Misses        6966     6972       +6     
+ Partials      1596     1592       -4

@erikjohnston erikjohnston merged commit 459d3d5 into develop Feb 18, 2019
@erikjohnston erikjohnston deleted the erikj/catch_exceptions branch March 5, 2019 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants