This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Tweak code coverage settings #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well lets see if codecov wakes up and makes of this PR. I've just enabled webhooks so hopefully it'll do something? |
Codecov Report
@@ Coverage Diff @@
## develop #4400 +/- ##
===========================================
+ Coverage 73.65% 73.65% +<.01%
===========================================
Files 300 300
Lines 29815 29815
Branches 4897 4897
===========================================
+ Hits 21960 21961 +1
+ Misses 6414 6412 -2
- Partials 1441 1442 +1 |
|
I don't know what happened to the commit statuses (maybe the config needs to be on the base branch?) but at least the comments are smaller. |
|
I'd like to leave this one for @hawkowl since I think she has more experience with codecov. I'm afraid I still don't really understand what the comment or report is trying to tell me. |
hawkowl
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were quite verbose, for not a lot of benefit. Also adds two commit statuses:
Currently they always pass, but we can set a minimum absolute threshold for coverage, or set it so that coverage must be better than the base branch.