-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
deleting the copyright-maintaining scripts feels a bit savage; the bug is that we don't use them, not that they exist... |
likewise, the directory map, whilst stale, is surely still useful for noobs? (but could be moved into /docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not block removing jenkins config with a discussion about what dev scripts we can remove, so can we split the PRs? (Or just delete the jenkins stuff)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
The map is stale enough that it is far more likely to be a hinderance than a help to anyone. There is no point having it unless it is maintained, and I don't believe that maintaining it is worthwhile.
I don't have strong feelings about the copyright scripts (they aren't cluttering up /, which helps). I'm not convinced that it is ever correct to go and replace the copyright notice wholesale on files which haven't been touched for some time (or those that have, by other contributors with other copyright notices). And anyway I don't really know how to use them. Personally I'd get rid of them but whatever.
@erikjohnston the map is the thing that I most want to kill off here. |
FWIW, the directory map is currently worse than nothing. If we want an explainer of what modules and folders are, we can put README.md's in them. As far as the copyright scripter, it isn't of much use (plus, the copyright header per file is not really... useful, but that's another thing). |
jenkins/prepare_synapse.sh is used by https://github.com/matrix-org/sytest/blob/develop/jenkins/sytest-sqlite.sh btw |
No description provided.