Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove Jenkins & other old dev junk #3988

Merged
merged 7 commits into from
Oct 2, 2018
Merged

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Oct 1, 2018

No description provided.

@ara4n
Copy link
Member

ara4n commented Oct 1, 2018

deleting the copyright-maintaining scripts feels a bit savage; the bug is that we don't use them, not that they exist...

@ara4n
Copy link
Member

ara4n commented Oct 1, 2018

likewise, the directory map, whilst stale, is surely still useful for noobs? (but could be moved into /docs)

@hawkowl hawkowl requested a review from a team October 2, 2018 11:51
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not block removing jenkins config with a discussion about what dev scripts we can remove, so can we split the PRs? (Or just delete the jenkins stuff)

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

The map is stale enough that it is far more likely to be a hinderance than a help to anyone. There is no point having it unless it is maintained, and I don't believe that maintaining it is worthwhile.

I don't have strong feelings about the copyright scripts (they aren't cluttering up /, which helps). I'm not convinced that it is ever correct to go and replace the copyright notice wholesale on files which haven't been touched for some time (or those that have, by other contributors with other copyright notices). And anyway I don't really know how to use them. Personally I'd get rid of them but whatever.

@richvdh
Copy link
Member

richvdh commented Oct 2, 2018

@erikjohnston the map is the thing that I most want to kill off here.

@hawkowl
Copy link
Contributor Author

hawkowl commented Oct 2, 2018

FWIW, the directory map is currently worse than nothing. If we want an explainer of what modules and folders are, we can put README.md's in them.

As far as the copyright scripter, it isn't of much use (plus, the copyright header per file is not really... useful, but that's another thing).

@richvdh
Copy link
Member

richvdh commented Oct 2, 2018

jenkins/prepare_synapse.sh is used by https://github.com/matrix-org/sytest/blob/develop/jenkins/sytest-sqlite.sh btw

@hawkowl hawkowl merged commit 058a4c6 into develop Oct 2, 2018
@hawkowl hawkowl deleted the hawkowl/remove-jenkins branch October 2, 2018 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants