Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove references to supporting per-user flag for msc2654 #15522

Merged
merged 4 commits into from
May 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/15522.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove references to supporting per-user flag for [MSC2654](https://github.com/matrix-org/matrix-spec-proposals/pull/2654) (#15522).
13 changes: 7 additions & 6 deletions docs/admin_api/experimental_features.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# Experimental Features API

This API allows a server administrator to enable or disable some experimental features on a per-user
basis. Currently supported features are [msc3026](https://github.com/matrix-org/matrix-spec-proposals/pull/3026): busy
presence state enabled, [msc2654](https://github.com/matrix-org/matrix-spec-proposals/pull/2654): enable unread counts,
[msc3881](https://github.com/matrix-org/matrix-spec-proposals/pull/3881): enable remotely toggling push notifications
for another client, and [msc3967](https://github.com/matrix-org/matrix-spec-proposals/pull/3967): do not require
basis. The currently supported features are:
- [MSC3026](https://github.com/matrix-org/matrix-spec-proposals/pull/3026): busy
presence state enabled
- [MSC3881](https://github.com/matrix-org/matrix-spec-proposals/pull/3881): enable remotely toggling push notifications
for another client
- [MSC3967](https://github.com/matrix-org/matrix-spec-proposals/pull/3967): do not require
UIA when first uploading cross-signing keys.


Expand All @@ -19,7 +21,7 @@ provide a body containing the user id and listing the features to enable/disable
{
"features": {
"msc3026":true,
"msc2654":true
"msc3881":true
}
}
```
Expand All @@ -46,7 +48,6 @@ user like so:
{
"features": {
"msc3026": true,
"msc2654": true,
"msc3881": false,
"msc3967": false
}
Expand Down
1 change: 0 additions & 1 deletion synapse/rest/admin/experimental_features.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class ExperimentalFeature(str, Enum):
"""

MSC3026 = "msc3026"
MSC2654 = "msc2654"
MSC3881 = "msc3881"
MSC3967 = "msc3967"

Expand Down
8 changes: 2 additions & 6 deletions tests/rest/admin/test_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def test_enable_and_disable(self) -> None:
"PUT",
url,
content={
"features": {"msc3026": True, "msc2654": True},
"features": {"msc3026": True, "msc3881": True},
},
access_token=self.admin_user_tok,
)
Expand All @@ -420,7 +420,7 @@ def test_enable_and_disable(self) -> None:
)
self.assertEqual(
True,
channel.json_body["features"]["msc2654"],
channel.json_body["features"]["msc3881"],
)

# test disabling a feature works
Expand Down Expand Up @@ -448,10 +448,6 @@ def test_enable_and_disable(self) -> None:
)
self.assertEqual(
True,
channel.json_body["features"]["msc2654"],
)
self.assertEqual(
False,
channel.json_body["features"]["msc3881"],
)
self.assertEqual(
Expand Down