Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Ensure portdb selects _all_ rows with negative rowids #13226

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Ensure portdb selects _all_ rows with negative rowids #13226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21e9fc5
Ensure portdb selects rows with negative rowids
Jul 8, 2022
d1decf6
Changelog
Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13226.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a long-standing bug where the `synapse_port_db` script could fail to copy rows with negative row ids.
5 changes: 4 additions & 1 deletion synapse/_scripts/synapse_port_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,12 +418,15 @@ async def handle_table(
self.progress.update(table, table_size) # Mark table as done
return

# We sweep over rowids in two directions: one forwards (rowids 1, 2, 3, ...)
# and another backwards (rowids 0, -1, -2, ...).
forward_select = (
"SELECT rowid, * FROM %s WHERE rowid >= ? ORDER BY rowid LIMIT ?" % (table,)
)

backward_select = (
"SELECT rowid, * FROM %s WHERE rowid <= ? ORDER BY rowid LIMIT ?" % (table,)
"SELECT rowid, * FROM %s WHERE rowid <= ? ORDER BY rowid DESC LIMIT ?"
% (table,)
)

do_forward = [True]
Expand Down