Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Document versions used for linting #8327

Closed
erikjohnston opened this issue Sep 16, 2020 · 1 comment · Fixed by #8330
Closed

Document versions used for linting #8327

erikjohnston opened this issue Sep 16, 2020 · 1 comment · Fixed by #8330
Labels
A-Docs things relating to the documentation Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution

Comments

@erikjohnston
Copy link
Member

We've pinned mypy and black in CI, so we should document that in https://github.com/matrix-org/synapse/blob/develop/CONTRIBUTING.md#code-style.

We could also add a pip install .[lint] that installed the right packages to make things easier.
@erikjohnston erikjohnston added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution A-Docs things relating to the documentation labels Sep 16, 2020
@clokep
Copy link
Member

clokep commented Sep 16, 2020

We should update tox to use this afterward. 👍

@ShadowJonathan ShadowJonathan mentioned this issue Sep 16, 2020
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Docs things relating to the documentation Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move lint dependencies to extras ShadowJonathan/synapse
2 participants
@clokep @erikjohnston