Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

synapse returns pointless body for OPTIONS requests #7857

Closed
richvdh opened this issue Jul 15, 2020 · 1 comment · Fixed by #7886
Closed

synapse returns pointless body for OPTIONS requests #7857

richvdh opened this issue Jul 15, 2020 · 1 comment · Fixed by #7886
Assignees
@clokep
Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Jul 15, 2020

we should just return a 204 No Content
@clokep
Copy link
Member

clokep commented Jul 15, 2020

I believe this requires messing with the OptionsResource but there might be some other places to touch too.

@erikjohnston erikjohnston added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label) labels Jul 17, 2020
@clokep clokep self-assigned this Jul 17, 2020
@clokep clokep mentioned this issue Jul 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return an empty body for OPTIONS requests. matrix-org/synapse
3 participants
@clokep @richvdh @erikjohnston