Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

simplify federation stream traffic #7549

Open
richvdh opened this issue May 21, 2020 · 0 comments
Open

simplify federation stream traffic #7549

richvdh opened this issue May 21, 2020 · 0 comments
Labels
A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented May 21, 2020

The federation replication stream has four types of row:

  • presence
  • presence_destinations
  • keyed_edus
  • edus

edus is completely unused afaict, and keyed_edus is only used for typing updates. This is somewhat important, as the federation stream is not reliable (we can drop rows during restarts). Additionally, since typing notifications are typically sent to a lot of destinations, there is a lot of duplication.

Could/should we replace keyed_edus and edus with a single typing row type, and while we're at it remove a bunch of dead code in FederationSender/FederationRemoteSendQueue/PerDestinationQueue (eg PerDestinationQueue._pending_edus is never used)?

@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. A-Workers Problems related to running Synapse in Worker Mode (or replication) and removed z-question (Deprecated Label) z-maintenance labels Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

3 participants