Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse 500s when /createRoom is given with a full alias instead of the alias's localpart #5127

Open
babolivier opened this issue May 2, 2019 · 0 comments
Open

Synapse 500s when /createRoom is given with a full alias instead of the alias's localpart #5127

babolivier opened this issue May 2, 2019 · 0 comments
Labels
A-Create-Room A-Validation 500 (mostly) errors due to lack of event/parameter validation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Milestone
Validate data pas...

Comments

@babolivier
Copy link
Contributor

babolivier commented May 2, 2019 •
edited
Loading

When /createRoom gets queried with, e.g. #qqqqqqqqqqqqqqqqq:matrix.org, as the value for room_alias_name, instead of qqqqqqqqqqqqqqqqq (which is what's supposed to go there), Synapse responds with a 500 status code and logs this error:

synapse.api.errors.RequestSendFailed: Failed to send request: InvalidCodepoint: Codepoint U+003A at position 4 of 'org:matrix' not allowed

It should return, e.g. a 400 with an error message explaining the localpart is expected in the request body.
@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels May 7, 2019
@richvdh richvdh added the A-Validation 500 (mostly) errors due to lack of event/parameter validation label Mar 19, 2020
@DMRobertson DMRobertson added O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. S-Minor Blocks non-critical functionality, workarounds exist. and removed z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Aug 25, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Create-Room A-Validation 500 (mostly) errors due to lack of event/parameter validation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
Validate data passed to REST endpoints
Development

No branches or pull requests
4 participants
@neilisfragile @richvdh @babolivier @DMRobertson