Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

It is possible to set a stupidly long displayname #5079

Open
richvdh opened this issue Apr 18, 2019 · 3 comments
Open

It is possible to set a stupidly long displayname #5079

richvdh opened this issue Apr 18, 2019 · 3 comments
Labels
A-Membership A-Validation 500 (mostly) errors due to lack of event/parameter validation P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches S-Tolerable Minor significance, cosmetic issues, low or no impact to users. Security T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Apr 18, 2019

... which then prevents you from being invited to rooms, as well as probably all manner of other DoS activities.
@Half-Shot Half-Shot mentioned this issue Apr 18, 2019
Closed
@neilisfragile neilisfragile added the z-p2 (Deprecated Label) label Apr 30, 2019
@Half-Shot Half-Shot mentioned this issue May 22, 2019
Closed
@richvdh
Copy link
Member Author

richvdh commented May 23, 2019

I think when I wrote this PR I was looking at displaynames so long that they didn't even fit in an event (65K). We should at least stop that happening. In general I see no problem with the actual limit being (server-)implementation-specific.

@richvdh richvdh mentioned this issue Jun 1, 2019
Merged
@richvdh
Copy link
Member Author

richvdh commented Jun 1, 2019 •
edited by anoadragon453
Loading

This is largely fixed by #5309; however it remains possible to set a long displayname in an individual room.

@aaronraimist
Copy link
Contributor

This isn't fully fixed yet @erikjohnston

@erikjohnston erikjohnston reopened this Jun 18, 2019
@DMRobertson DMRobertson added P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. and removed z-p2 (Deprecated Label) labels Jan 27, 2022
@MadLittleMods MadLittleMods added A-Validation 500 (mostly) errors due to lack of event/parameter validation A-Membership labels May 16, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Membership A-Validation 500 (mostly) errors due to lack of event/parameter validation P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches S-Tolerable Minor significance, cosmetic issues, low or no impact to users. Security T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@callahad @neilisfragile @MadLittleMods @richvdh @aaronraimist @erikjohnston @DMRobertson