Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Application Service API (PUT transaction) weird behaviour #3132

Closed
oliverjanik opened this issue Apr 26, 2018 · 3 comments
Closed

Application Service API (PUT transaction) weird behaviour #3132

oliverjanik opened this issue Apr 26, 2018 · 3 comments
Labels
A-Application-Service Related to AS support A-Docs things relating to the documentation z-p3 (Deprecated Label)

Comments

@oliverjanik
Copy link

https://matrix.org/docs/spec/application_service/unstable.html

Under 2.2.3.1 PUT /transactions/{txnId} it says:

Response:

Status code 200:

The transaction was processed successfully.

Example

{}

It's not very clear that Synapse expects an empty json object back. I just had a 200 with empty response and it kept re-sending transaction 1.

I guess it's either a Synapse bug or the spec should be clearer?

@neilisfragile neilisfragile added z-p3 (Deprecated Label) A-Docs things relating to the documentation labels May 9, 2018
@neilisfragile
Copy link
Contributor

The alternative is to return a 204 No Content - we do it this way (as a convention across the spec) to make it easier to add content in the future without having to change the response code.

@oliverjanik
Copy link
Author

It makes sense, I just completely missed that {} is an empty json object and it's mandatory.

@richvdh
Copy link
Member

richvdh commented Oct 20, 2020

seems like a spec issue

@richvdh richvdh closed this as completed Oct 20, 2020
@MadLittleMods MadLittleMods added the A-Application-Service Related to AS support label Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support A-Docs things relating to the documentation z-p3 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

4 participants