Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Many endpoints that serialize events don't include the transaction_id #15173

Closed
sandhose opened this issue Feb 28, 2023 · 0 comments · Fixed by #15174
Closed

Many endpoints that serialize events don't include the transaction_id #15173

sandhose opened this issue Feb 28, 2023 · 0 comments · Fixed by #15174
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@sandhose
Copy link
Member

According to the spec, there are many endpoints that should include the transaction_id in the unsigned section of the event. Those endpoints are:

/sync
/rooms/{roomId}/state
/rooms/{roomId}/state/{eventType}/{stateKey}
/rooms/{roomId}/context/{eventId}
/rooms/{roomId}/messages
/rooms/{roomId}/relations/{eventId}
/rooms/{roomId}/relations/{eventId}/{relType}
/rooms/{roomId}/event/{eventId}
/rooms/{roomId}/threads
/search
/rooms/{roomId}/initialSync # Deprecated
/events # Deprecated

Synapse only does that on the /sync endpoint. I have a Complement test to highlight that issue using the /rooms/{roomId}/event/{eventId} endpoint.

@H-Shay H-Shay added A-Spec-Compliance places where synapse does not conform to the spec T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Blocks non-critical functionality, workarounds exist. labels Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants