Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add Synapse-Trace-Id to access-control-allow-headers header #14951

Closed
bwindels opened this issue Jan 31, 2023 · 1 comment · Fixed by #14974
Closed

Add Synapse-Trace-Id to access-control-allow-headers header #14951

bwindels opened this issue Jan 31, 2023 · 1 comment · Fixed by #14974
Assignees
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@bwindels
Copy link
Contributor

Description

The Synapse-Trace-Id response header added in #9480 needs to be whitelisted as well so web clients using CORS can read it.

Steps to reproduce

one a jaeger enabled synapse, make a request that is traced by jaeger.

Homeserver

matrix.org

Synapse Version

1.76.0rc1

Installation Method

I don't know

Database

don't know

Workers

I don't know

Platform

don't know

Configuration

No response

Relevant log output

don't have any

Anything else that would be useful to know?

No response

@DMRobertson DMRobertson added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jan 31, 2023
@H-Shay H-Shay self-assigned this Feb 2, 2023
@H-Shay
Copy link
Contributor

H-Shay commented Feb 8, 2023

cross-posting from #14974 for visibility:

@bwindels We're a bit confused about which header Synapse-Trace-Id needs to be added to. Surely it's Access-Control-Expose-Headers, so that clients can read the trace id?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants