Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Rooms can get into a very confused state where guests' join requests are 200ed but never actually joined (SYN-623) #1492

Open
matrixbot opened this issue Feb 8, 2016 · 4 comments
Labels
A-Guests A-Join Joining a room (there is another label for federated joins) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@matrixbot
Copy link
Member

element-hq/element-web#884

(Imported from https://matrix.org/jira/browse/SYN-623)

(Reported by @dbkr)

@matrixbot
Copy link
Member Author

Jira watchers: @dbkr

@matrixbot
Copy link
Member Author

The room #testingGuest:matrix.org appears to have started out with guest access enabled and then has it disabled. When loading the timeline for this room, the state is given with guest access enabled (since this reflects the state at the point represented by the start of the timeline) and the timeline then contains an event setting guest access to disabled.

Currently this can be witnessed by creating a guest account on matrix.org from vector, clicking on 'Testing Guest Access' in the directory and clicking join. No composer bar appears because the join request succeeds but there is no join event for the user in the room state that comes down.

Unsure yet whether it's possible to get a new room into this state.

-- @dbkr

@matrixbot
Copy link
Member Author

Better still, when I sync my account, the room comes down with state guest_access: can_join and no guest_access state events in the timeline (the timeline has 7 events). When I try to join the room as a guest, I get the same room state but a timeline 10 events, of which the last (9) is Amandine setting guest_access to forbidden with event id $145461849139154seYfI:matrix.org!

-- @dbkr

@matrixbot matrixbot changed the title Rooms can get into a very confused state where guests' join requests are 200ed but never actually joined (SYN-623) Rooms can get into a very confused state where guests' join requests are 200ed but never actually joined (https://github.com/matrix-org/synapse/issues/1492) Nov 7, 2016
@matrixbot matrixbot changed the title Rooms can get into a very confused state where guests' join requests are 200ed but never actually joined (https://github.com/matrix-org/synapse/issues/1492) Rooms can get into a very confused state where guests' join requests are 200ed but never actually joined (SYN-623) Nov 7, 2016
@DMRobertson DMRobertson added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. A-Guests A-Join Joining a room (there is another label for federated joins) labels Apr 26, 2023
@DMRobertson
Copy link
Contributor

7 years later, we should try to reproduce this or else close it.

@DMRobertson DMRobertson added S-Minor Blocks non-critical functionality, workarounds exist. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Guests A-Join Joining a room (there is another label for federated joins) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

2 participants