Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Joining and leaving a room in the same batch should result in a full state sync (SYN-514) #1413

Open
matrixbot opened this issue Nov 8, 2015 · 4 comments
Open

Joining and leaving a room in the same batch should result in a full state sync (SYN-514) #1413

matrixbot opened this issue Nov 8, 2015 · 4 comments
Labels
A-Sync defects related to /sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@matrixbot
Copy link
Member

Submitted by @​richvdh:matrix.org
If a user joins a room, then immediately leaves it, so that /sync returns both events in the same batch - should /sync return the complete state for that room (as it does normally when joining a room)?

(Imported from https://matrix.org/jira/browse/SYN-514)
@matrixbot matrixbot added z-p5 (Deprecated Label) z-bug (Deprecated Label) labels Nov 7, 2016
@matrixbot matrixbot changed the title Joining and leaving a room in the same batch should result in a full state sync (SYN-514) Joining and leaving a room in the same batch should result in a full state sync (https://github.com/matrix-org/synapse/issues/1413) Nov 7, 2016
@matrixbot matrixbot changed the title Joining and leaving a room in the same batch should result in a full state sync (https://github.com/matrix-org/synapse/issues/1413) Joining and leaving a room in the same batch should result in a full state sync (SYN-514) Nov 7, 2016
@richvdh
Copy link
Member

richvdh commented Oct 9, 2020

this is related to, and possibly the same as #3305

@richvdh richvdh mentioned this issue Nov 25, 2020
Closed
@Dominaezzz
Copy link

Is this according to the spec?

@ShadowJonathan
Copy link
Contributor

I think the spec is UB on this, but i can see the reasoning for this; this could happen when clients havent synced for a while, and over a sync batch, the user has already joined and left a room via another client. This should show up in the syncing client as a "historical" room, thus enabling inspection from that room.

@anoadragon453
Copy link
Member

Perhaps Synapse should just return the latest state event (the interim membership change may not matter to the client?).

@erikjohnston erikjohnston added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. and removed z-bug (Deprecated Label) labels Jul 23, 2021
@DMRobertson DMRobertson added A-Sync defects related to /sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. and removed z-p5 (Deprecated Label) S-Minor Blocks non-critical functionality, workarounds exist. labels Sep 27, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Sync defects related to /sync O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@anoadragon453 @richvdh @erikjohnston @DMRobertson @matrixbot @Dominaezzz @ShadowJonathan