Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Setting receipts from client doesn't mind syntactically-invalid event IDs (SYN-512) #1412

Open
matrixbot opened this issue Nov 3, 2015 · 2 comments
Open

Setting receipts from client doesn't mind syntactically-invalid event IDs (SYN-512) #1412

matrixbot opened this issue Nov 3, 2015 · 2 comments
Labels
A-Validation 500 (mostly) errors due to lack of event/parameter validation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Milestone
Validate data pas...

Comments

@matrixbot
Copy link
Member

From sytest:

Response from POST /_matrix/client/v2_alpha/rooms/!aDJeXAaoqXQuEXEOKb:localhost:8001/receipt/m.read/TODOEVENTID for user=@​_ANON_-19:localhost:8001:
  HTTP/1.1 200 OK

I would have expected some 400-series error, as this isn't even syntactically valid as an event ID. Additionally, I'd probably expect synapse to complain if the given event ID didn't exist in the room, although there might be spec/impl. reasons to accept that anyway? I'm not sure.

(Imported from https://matrix.org/jira/browse/SYN-512)

(Reported by @leonerd)
@matrixbot
Copy link
Member Author

Jira watchers: @leonerd

@matrixbot matrixbot changed the title Setting receipts from client doesn't mind syntactically-invalid event IDs (SYN-512) Setting receipts from client doesn't mind syntactically-invalid event IDs (https://github.com/matrix-org/synapse/issues/1412) Nov 7, 2016
@matrixbot matrixbot changed the title Setting receipts from client doesn't mind syntactically-invalid event IDs (https://github.com/matrix-org/synapse/issues/1412) Setting receipts from client doesn't mind syntactically-invalid event IDs (SYN-512) Nov 7, 2016
@ptman
Copy link
Contributor

ptman commented Apr 13, 2022

Is this still the case?

@erikjohnston erikjohnston added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Apr 13, 2022
@DMRobertson DMRobertson added A-Validation 500 (mostly) errors due to lack of event/parameter validation O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 27, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Validation 500 (mostly) errors due to lack of event/parameter validation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
Validate data passed to REST endpoints
Development

No branches or pull requests
4 participants
@ptman @erikjohnston @DMRobertson @matrixbot