Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Missing validation on typing EDUs #13869

Closed
squahtx opened this issue Sep 22, 2022 · 0 comments · Fixed by #13830
Closed

Missing validation on typing EDUs #13869

squahtx opened this issue Sep 22, 2022 · 0 comments · Fixed by #13830
Labels
A-Federation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@squahtx
Copy link
Contributor

squahtx commented Sep 22, 2022

When we receive a typing EDU from a remote homeserver, we neglect to check that said homeserver is in the room the typing EDU is for.

There was a check that looked like it was doing the job, except it was really checking that the local homeserver is in the room a second time:

domains = await self._storage_controllers.state.get_current_hosts_in_room(
room_id
)
if self.server_name in domains:

related: #11456

@squahtx squahtx added A-Federation S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Federation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant