Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Upgrade mypy to 0.971 or newer #13500

Closed
DMRobertson opened this issue Aug 11, 2022 · 4 comments · Fixed by #13521, #13925 or #13993
Closed

Upgrade mypy to 0.971 or newer #13500

DMRobertson opened this issue Aug 11, 2022 · 4 comments · Fixed by #13521, #13925 or #13993
Assignees
@DMRobertson
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact

Comments

@DMRobertson
Copy link
Contributor

We have currently locked mypy 0.950. Since then, 0.960 and 0.971 have been released. I am particularly interested by ParamSpec-related fixes and improvements to the stdlib stubs in typeshed.

Now that a sufficiently new version of mypy-zope is available, we should upgrade mypy and mypy-zope to take advantage of the latest improvements.
@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact labels Aug 11, 2022
@DMRobertson
Copy link
Contributor Author

WIP at https://github.com/matrix-org/synapse/tree/dmr/mypy-upgrade

@DMRobertson DMRobertson mentioned this issue Aug 12, 2022
Merged
@DMRobertson
Copy link
Contributor Author

There were a bunch of failures on other PRs (but none on #13521 itself?). Needs investigation later.

@DMRobertson DMRobertson reopened this Aug 15, 2022
@DMRobertson
Copy link
Contributor Author

0.981 is now available.

@DMRobertson
Copy link
Contributor Author

There were a bunch of failures on other PRs (but none on #13521 itself?). Needs investigation later.

I suspect something went wrong with mypy's cache. python/mypy#10221 looks related, and also mentions mypy-zope. How suspicious!!

This was referenced Sep 27, 2022
Closed
Merged
@DMRobertson DMRobertson changed the title Upgrade mypy to 0.971 Upgrade mypy to 0.971 or newer Sep 28, 2022
@DMRobertson DMRobertson self-assigned this Sep 28, 2022
@DMRobertson DMRobertson reopened this Sep 30, 2022
@DMRobertson DMRobertson linked a pull request Sep 30, 2022 that will close this issue
Update mypy and mypy-zope, attempt 3 #13993
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact
Projects
None yet
Milestone
No milestone
1 participant
@DMRobertson