Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Backfill can cause large memory spikes in private rooms #13244

Open
erikjohnston opened this issue Jul 11, 2022 · 1 comment
Open

Backfill can cause large memory spikes in private rooms #13244

erikjohnston opened this issue Jul 11, 2022 · 1 comment
Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Milestone
Server Density

Comments

@erikjohnston
Copy link
Member

This is because we call filter_events_for_server, which will fetch all member events in the room at every backwards extremity when history visibility is not shared or wold readable.
@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jul 11, 2022
@erikjohnston erikjohnston added this to the Server Density milestone Jul 11, 2022
@richvdh
Copy link
Member

richvdh commented Jul 11, 2022

related: #4094, #3526, #8554

I think they might all be symptoms of the same problem?

@MadLittleMods MadLittleMods added the A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) label Jul 19, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
Server Density
Development

No branches or pull requests
3 participants
@MadLittleMods @richvdh @erikjohnston