Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We should check "depth" increases. (SYN-196) #1254

Open
matrixbot opened this issue Dec 10, 2014 · 7 comments
Open

We should check "depth" increases. (SYN-196) #1254

matrixbot opened this issue Dec 10, 2014 · 7 comments
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@matrixbot
Copy link
Member

(Imported from https://matrix.org/jira/browse/SYN-196)

(Reported by @erikjohnston)
@matrixbot
Copy link
Member Author

Jira watchers: @erikjohnston

@matrixbot matrixbot added the z-bug (Deprecated Label) label Nov 7, 2016
@matrixbot matrixbot changed the title We should check "depth" increases. (SYN-196) We should check "depth" increases. (https://github.com/matrix-org/synapse/issues/1254) Nov 7, 2016
@matrixbot matrixbot changed the title We should check "depth" increases. (https://github.com/matrix-org/synapse/issues/1254) We should check "depth" increases. (SYN-196) Nov 7, 2016
@richvdh richvdh mentioned this issue May 12, 2018
Closed
@turt2live turt2live mentioned this issue Nov 11, 2018
Closed
14 tasks
@clokep clokep added the A-Spec-Compliance places where synapse does not conform to the spec label Apr 29, 2020
@richvdh
Copy link
Member

richvdh commented Jun 2, 2020

related: #1646

@ara4n
Copy link
Member

ara4n commented Sep 26, 2020

erm, #1646 is nothing to do with this?

Meanwhile, i thought we no longer trusted depth, and this bug is hopefully irrelevant?

@richvdh
Copy link
Member

richvdh commented Sep 28, 2020

erm, #1646 is nothing to do with this?

Indeed; no idea what I meant to link to here.

Meanwhile, i thought we no longer trusted depth, and this bug is hopefully irrelevant?

depth is still used in back-pagination and elsewhere.

@richvdh
Copy link
Member

richvdh commented Sep 28, 2020

see in particular: #3785.

@ShadowJonathan
Copy link
Contributor

Uhhhh, what is "depth" in this context, exactly?

I dont have any context with this issue, that's why i'm asking.

@richvdh
Copy link
Member

richvdh commented Feb 24, 2021

@ShadowJonathan: see https://matrix.org/docs/spec/rooms/v1#persistent-data-unit-schema

@reivilibre reivilibre added T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-bug (Deprecated Label) labels May 19, 2023
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Spec-Compliance places where synapse does not conform to the spec O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@clokep @ara4n @richvdh @matrixbot @ShadowJonathan @reivilibre