Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Stabilize support for MSC3440: thread relation #12148

Closed
3 tasks done
clokep opened this issue Mar 3, 2022 · 4 comments · Fixed by #12382
Closed
3 tasks done

Stabilize support for MSC3440: thread relation #12148

clokep opened this issue Mar 3, 2022 · 4 comments · Fixed by #12382
Assignees
@clokep
Labels
A-Threads Threaded messages T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Mar 3, 2022 •
edited
Loading

MSC3440 is currently in a final comment period. We'll need to make a few tweaks to stabilize support for it:

  • Use the proper serialization configuration: Change latest_event format in thread bundled relationship #12085
  • Support stable identifiers:
    • io.element.relation_senders -> related_by_senders
    • io.element.relation_types -> related_by_rel_types
    • io.element.thread -> m.thread
  • Remove experimental configuration flag and unstable identifiers.

We'll probably want to overlap support of stable & unstable identifiers for a couple of releases.

See also: #11753.
@clokep clokep added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. A-Threads Threaded messages labels Mar 3, 2022
@clokep clokep self-assigned this Mar 3, 2022
@clokep
Copy link
Member Author

clokep commented Mar 3, 2022

See also a cache invalidation bug with thread summaries: #12104

@clokep clokep mentioned this issue Mar 3, 2022
Merged
@Nira34

This comment was marked as spam.

Sign in to view
@clokep
Copy link
Member Author

clokep commented Mar 10, 2022

This is landing in v1.55.0, so should probably remove the unstable identifiers in 1.57.0 or so.

@clokep clokep mentioned this issue Apr 5, 2022
Merged
@clokep clokep changed the title Stabilize support for MSC3440 Stabilize support for MSC3440: thread relation Apr 6, 2022
@clokep
Copy link
Member Author

clokep commented Apr 12, 2022

Support for the unstable identifiers will be dropped in v1.58.0. Note that this will cause old clients to fallback to their local-only implementation of unstable threads, but this should be fine since people will eventually update to stable threads / clients.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Threads Threaded messages T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove references to unstable identifiers from MSC3440. matrix-org/synapse
2 participants
@clokep @Nira34