Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

require Collections rather than Iterables in storage functions #11569

Closed
richvdh opened this issue Dec 13, 2021 · 1 comment · Fixed by #11580
Closed

require Collections rather than Iterables in storage functions #11569

richvdh opened this issue Dec 13, 2021 · 1 comment · Fixed by #11580
Assignees
@clokep
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented Dec 13, 2021

There are various methods in DatabasePool (such as simple_insert_many_values) which claim to take arbitrary Iterables as arguments when in fact they cannot be generators (since they may be evaluated more than once: see #11564).

We should change their definitions to Collection.
@richvdh richvdh mentioned this issue Dec 13, 2021
Merged
@richvdh
Copy link
Member Author

richvdh commented Dec 13, 2021

(note: this does not generally apply to _txn variants, because they do not pass their arguments to runInteraction and hence do not evaluate them multiple times.)

@reivilibre reivilibre added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Dec 14, 2021
@clokep clokep self-assigned this Dec 14, 2021
@clokep clokep mentioned this issue Dec 14, 2021
Merged
@DMRobertson DMRobertson mentioned this issue Apr 20, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require Collections for simple_* methods. matrix-org/synapse
3 participants
@clokep @richvdh @reivilibre