Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

test_global_instantiated_before_config_load is flaky #11007

Closed
clokep opened this issue Oct 6, 2021 · 4 comments · Fixed by #11019 or #11036
Closed

test_global_instantiated_before_config_load is flaky #11007

clokep opened this issue Oct 6, 2021 · 4 comments · Fixed by #11019 or #11036
Assignees
@clokep
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Oct 6, 2021

https://github.com/matrix-org/synapse/runs/3816535717 and https://github.com/matrix-org/synapse/runs/3818555537

This was recently rewritten in #10985.
@clokep clokep self-assigned this Oct 6, 2021
@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Oct 6, 2021
@richvdh
Copy link
Member

richvdh commented Oct 7, 2021

test_individual_instantiated_before_config_load seems flaky too, per https://github.com/matrix-org/synapse/pull/11009/checks?check_run_id=3820490383.

@clokep
Copy link
Member Author

clokep commented Oct 7, 2021

Thanks! I kind of suspect they all are since they mess with global state? I'm not sure why this would just happen now though. 😢

@clokep clokep mentioned this issue Oct 7, 2021
Merged
@DMRobertson DMRobertson mentioned this issue Oct 7, 2021
Merged
@clokep
Copy link
Member Author

clokep commented Oct 8, 2021

Seems #11028 had this even with the "fix".

@clokep clokep reopened this Oct 8, 2021
@clokep clokep mentioned this issue Oct 8, 2021
Merged
@DMRobertson
Copy link
Contributor

We think this is fixed by merging in #11036. If it crops up again, we can reopen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
3 participants
@clokep @richvdh @DMRobertson