Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Exceptions from presence handling in 1.44.0rc1 #10941

Closed
richvdh opened this issue Sep 29, 2021 · 0 comments
Closed

Exceptions from presence handling in 1.44.0rc1 #10941

richvdh opened this issue Sep 29, 2021 · 0 comments
Assignees
Labels
A-Presence S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release

Comments

@richvdh
Copy link
Member

richvdh commented Sep 29, 2021

2021-09-29 16:09:28,131 - synapse.metrics.background_process_metrics - 215 - ERROR - notify_interested_services_ephemeral-0 - Background process 'notify_interested_services_ephemeral' threw an exception
Traceback (most recent call last):
  File "synapse/metrics/background_process_metrics.py", line 213, in run
    return await maybe_awaitable(func(*args, **kwargs))
  File "synapse/handlers/appservice.py", line 247, in _notify_interested_services_ephemeral
    events = await self._handle_presence(service, users)
  File "synapse/handlers/appservice.py", line 293, in _handle_presence
    presence_events, _ = await presence_source.get_new_events(
  File "synapse/logging/utils.py", line 69, in wrapped
    return f(*args, **kwargs)
TypeError: get_new_events() got an unexpected keyword argument 'service'

looks like something changed here in 4054dfa

@richvdh richvdh added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release labels Sep 29, 2021
@reivilibre reivilibre self-assigned this Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Presence S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

No branches or pull requests

4 participants