Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

tie lint output into github annotations #10622

Open
richvdh opened this issue Aug 17, 2021 · 3 comments
Open

tie lint output into github annotations #10622

richvdh opened this issue Aug 17, 2021 · 3 comments
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented Aug 17, 2021

In github actions, it's possible to define some regexes which get matched against the script output, and allow individual lines in the PR to be annotated accordingly. It would be nice to do this for our linters.

See https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md, and https://github.com/TrueBrain/actions-flake8/blob/main/action/flake8-matcher.json for an example

@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Aug 23, 2021
@callahad callahad added the P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches label Sep 2, 2021
@callahad
Copy link
Contributor

callahad commented Sep 2, 2021

Would be very nice to have, but not sure we're going to be able to formally prioritize. For an example, dig into https://github.com/twisted/twisted/

@richvdh
Copy link
Member Author

richvdh commented Sep 2, 2021

see https://github.com/twisted/twisted/pull/1631/files#diff-0aee9d699c9dba9eb4f2ea2d21a1ab0b4b3d90eda2fa31a31a02c143b975a101R670 for example of annotations on PR branches. (Of course, that annotation may have been fixed by the time you read this)

@richvdh
Copy link
Member Author

richvdh commented Sep 2, 2021

ah, in that case it might be codecov.io which adds the annotation, rather than GHA itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

3 participants