Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Application Service URIs not treated as URIs #10012

Closed
martindale opened this issue May 18, 2021 · 3 comments
Closed

Application Service URIs not treated as URIs #10012

martindale opened this issue May 18, 2021 · 3 comments
Labels
A-Application-Service Related to AS support

Comments

@martindale
Copy link

Using URIs in Application Service configuration do not appear to be parsed as URIs, but rather with some kind of custom heuristic.

Steps to reproduce

  • Configure an Application Service using an URI like https://USERNAME:PASSWORD@somehost.local/services/matrix
  • Observe failed connection to :PASSWORD@somehost.local

If this were parsed as a URI, which I believe is the intention, the HTTP client should receive correct Authorization headers for the application service.

Version information

  • Version: 1.28.0

  • Install method:
    pip

  • Platform:
    Ubuntu 20.10

@tulir
Copy link
Member

tulir commented May 19, 2021

IMO this should not be fixed as it's incompatible with matrix-org/matrix-spec-proposals#2832

@erikjohnston
Copy link
Member

erikjohnston commented May 20, 2021

I think that supporting using USERNAME:PASSWORD in application services would conflict with the use of an access_token? So even if we did correctly parse the URL we'd likely just reject it. Do you have a use case for this?

@erikjohnston erikjohnston added the X-Needs-Info This issue is blocked awaiting information from the reporter label May 20, 2021
@richvdh
Copy link
Member

richvdh commented Jul 22, 2021

sounds like this isn't a thing we have a viable usecase for.

@richvdh richvdh closed this as completed Jul 22, 2021
@MadLittleMods MadLittleMods added the A-Application-Service Related to AS support label Dec 23, 2022
@H-Shay H-Shay removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support
Projects
None yet
Development

No branches or pull requests

6 participants