Fix logging error when a tampered event is detected. (#5500)

anoadragon453 · anoadragon453 · commit f6905719cf5a · 2020-02-13T11:58:46.000Z
diff --git a/changelog.d/5500.bugfix b/changelog.d/5500.bugfix
@@ -0,0 +1 @@
+Fix logging error when a tampered event is detected.
diff --git a/synapse/federation/federation_base.py b/synapse/federation/federation_base.py
@@ -163,7 +163,6 @@ def callback(_, pdu):
                         logger.warning(
                             "Event %s content has been tampered, redacting",
                             pdu.event_id,
-                            pdu.get_pdu_json(),
                         )
                     return redacted_event
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix logging error when a tampered event is detected.`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,6 @@ def callback(_, pdu):`
`163`	`163`	`logger.warning(`
`164`	`164`	`"Event %s content has been tampered, redacting",`
`165`	`165`	`pdu.event_id,`
`166`		`- pdu.get_pdu_json(),`
`167`	`166`	`)`
`168`	`167`	`return redacted_event`
`169`	`168`