Enforce all replication HTTP clients calls use kwargs (#9144)

Author: erikjohnston

changelog.d/9144.misc

@@ -0,0 +1 @@
+Enforce that replication HTTP clients are called with keyword arguments only.

synapse/replication/http/_base.py

@@ -177,7 +177,7 @@ def make_client(cls, hs):
 
         @trace(opname="outgoing_replication_request")
         @outgoing_gauge.track_inprogress()
-        async def send_request(instance_name="master", **kwargs):
+        async def send_request(*, instance_name="master", **kwargs):
             if instance_name == local_instance_name:
                 raise Exception("Trying to send HTTP request to self")
             if instance_name == "master":