Add use_float=true to ijson calls in Synapse (#11217)

H-Shay · squahtx · web-flow · commit e81fa9264873 · 2021-11-01T09:28:04.000-07:00
* add use_float=true to ijson calls

* lints

* add changelog

* Update changelog.d/11217.bugfix

Co-authored-by: Sean Quah &lt;8349537+squahtx@users.noreply.github.com&gt;

Co-authored-by: Sean Quah &lt;8349537+squahtx@users.noreply.github.com&gt;
diff --git a/changelog.d/11217.bugfix b/changelog.d/11217.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in 1.35.0 which made it impossible to join rooms that return a `send_join` response containing floats.
diff --git a/synapse/federation/transport/client.py b/synapse/federation/transport/client.py
@@ -1310,14 +1310,17 @@ def __init__(self, room_version: RoomVersion, v1_api: bool):
         self._coro_state = ijson.items_coro(
             _event_list_parser(room_version, self._response.state),
             prefix + "state.item",
+            use_float=True,
         )
         self._coro_auth = ijson.items_coro(
             _event_list_parser(room_version, self._response.auth_events),
             prefix + "auth_chain.item",
+            use_float=True,
         )
         self._coro_event = ijson.kvitems_coro(
             _event_parser(self._response.event_dict),
             prefix + "org.matrix.msc3083.v2.event",
+            use_float=True,
         )
 
     def write(self, data: bytes) -> int:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix a bug introduced in 1.35.0 which made it impossible to join rooms that return a `send_join` response containing floats.
Original file line number	Diff line number	Diff line change
`@@ -1310,14 +1310,17 @@ def __init__(self, room_version: RoomVersion, v1_api: bool):`
`1310`	`1310`	`self._coro_state = ijson.items_coro(`
`1311`	`1311`	`_event_list_parser(room_version, self._response.state),`
`1312`	`1312`	`prefix + "state.item",`
	`1313`	`+ use_float=True,`
`1313`	`1314`	`)`
`1314`	`1315`	`self._coro_auth = ijson.items_coro(`
`1315`	`1316`	`_event_list_parser(room_version, self._response.auth_events),`
`1316`	`1317`	`prefix + "auth_chain.item",`
	`1318`	`+ use_float=True,`
`1317`	`1319`	`)`
`1318`	`1320`	`self._coro_event = ijson.kvitems_coro(`
`1319`	`1321`	`_event_parser(self._response.event_dict),`
`1320`	`1322`	`prefix + "org.matrix.msc3083.v2.event",`
	`1323`	`+ use_float=True,`
`1321`	`1324`	`)`
`1322`	`1325`
`1323`	`1326`	`def write(self, data: bytes) -> int:`