Fix logging error on SIGHUP (#14258)

richvdh · web-flow · commit d24346f53055 · 2022-10-21T16:03:44.000+01:00
diff --git a/changelog.d/14258.bugfix b/changelog.d/14258.bugfix
@@ -0,0 +1,2 @@
+Fix a bug introduced in Synapse 1.60.0 which caused an error to be logged when Synapse received a SIGHUP signal, and debug logging was enabled.
+
diff --git a/synapse/app/_base.py b/synapse/app/_base.py
@@ -558,7 +558,7 @@ def reload_cache_config(config: HomeServerConfig) -> None:
             logger.warning(f)
     else:
         logger.debug(
-            "New cache config. Was:\n %s\nNow:\n",
+            "New cache config. Was:\n %s\nNow:\n %s",
             previous_cache_config.__dict__,
             config.caches.__dict__,
         )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Fix a bug introduced in Synapse 1.60.0 which caused an error to be logged when Synapse received a SIGHUP signal, and debug logging was enabled.`
	`2`	`+`
Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,7 @@ def reload_cache_config(config: HomeServerConfig) -> None:`
`558`	`558`	`logger.warning(f)`
`559`	`559`	`else:`
`560`	`560`	`logger.debug(`
`561`		`- "New cache config. Was:\n %s\nNow:\n",`
	`561`	`+ "New cache config. Was:\n %s\nNow:\n %s",`
`562`	`562`	`previous_cache_config.__dict__,`
`563`	`563`	`config.caches.__dict__,`
`564`	`564`	`)`